Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

docs: confirm flannel + docker is not supported #3886

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Oct 1, 2020

Reason for Change:

This PR adds explicit documentation about the flannel addon only being supported with containerd, and api model validation.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot acs-bot added the size/M label Oct 1, 2020
@acs-bot
Copy link

acs-bot commented Oct 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #3886 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3886   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files         149      149           
  Lines       23203    23205    +2     
=======================================
+ Hits        16900    16902    +2     
  Misses       5182     5182           
  Partials     1121     1121           
Impacted Files Coverage Δ
pkg/api/vlabs/validate.go 78.96% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908214e...6f26bb0. Read the comment docs.

@jackfrancis jackfrancis merged commit 0074c24 into Azure:master Oct 2, 2020
@jackfrancis jackfrancis deleted the docs-flannel-containerd branch October 2, 2020 21:06
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants